Add has_projects field to github repository #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
requested changes
Mar 17, 2020
| * @param v | ||
| * the v | ||
| * @throws IOException | ||
| * the io exception |
There was a problem hiding this comment.
This will probably fail formatting, but we need links to the api docs.
Suggested change
| * the io exception | |
| * the io exception | |
| * @see https://developer.github.com/v3/repos/#parameters-4 |
Yeah will add it, I was just wondering how do I add a file to the wiremock |
|
@sladyn98 |
|
While writing test for this, found #765 . 😭 |
bitwiseman
force-pushed
the
add_has_projects
branch
2 times, most recently
from
02fd57d to
279df00
Compare
bitwiseman
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
has_projectsfield to the Github API.Closes: #661
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.