Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CheckRuns] Add method for listing checkruns for given ref #740

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

avano
Copy link
Contributor

@avano avano commented Mar 14, 2020

Description

  • Add a method for GHCommit and GHRepository for listing the check-runs for given sha
  • Add tests for getting check-run for given commit and for getting the last status of given commit
  • Added missing enum for GitHub registry_package event

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

@avano avano force-pushed the list-checkruns-for-ref branch from 59d04e7 to 2afffdd Compare March 14, 2020 18:03
@avano avano force-pushed the list-checkruns-for-ref branch 2 times, most recently from df0a3ff to 04dca90 Compare March 17, 2020 16:07
@avano
Copy link
Contributor Author

avano commented Mar 17, 2020

@bitwiseman I incorporated the suggested change manually, as after accepting it the build complained about it being incorrectly formatted 😀

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but it needs to use the paging framework. This is in the api documentation, but is still non-obvious. Sorry.

@avano avano force-pushed the list-checkruns-for-ref branch from 04dca90 to 3b9c4a4 Compare March 19, 2020 16:40
@avano avano requested a review from bitwiseman March 19, 2020 17:00
@avano
Copy link
Contributor Author

avano commented Mar 19, 2020

also added missing registry_package event that caused problems when fetching check runs from github-api repository

@avano avano force-pushed the list-checkruns-for-ref branch from 3b9c4a4 to 452b56c Compare March 20, 2020 10:47
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bitwiseman bitwiseman merged commit 3daccbd into hub4j:master Mar 20, 2020
@jglick jglick mentioned this pull request Mar 25, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants