-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CheckRuns] Add method for listing checkruns for given ref #740
Conversation
59d04e7
to
2afffdd
Compare
df0a3ff
to
04dca90
Compare
@bitwiseman I incorporated the suggested change manually, as after accepting it the build complained about it being incorrectly formatted 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but it needs to use the paging framework. This is in the api documentation, but is still non-obvious. Sorry.
04dca90
to
3b9c4a4
Compare
also added missing |
3b9c4a4
to
452b56c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
GHCommit
andGHRepository
for listing the check-runs for given sharegistry_package
eventBefore submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master
. Create your PR from that branch.mvn -D enable-ci clean install site
locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.