Remove a few long deprecated methods and fully annotate others #719
Conversation
|
@Sage-Pierce @nobe0716 |
|
LGTM - Are you planning on releasing with a major rev since this is technically backward incompatible? |
bitwiseman
force-pushed
the
task/deprecated
branch
from
98fc6cf to
5e5708d
Compare
|
@Sage-Pierce |
| @@ -63,23 +63,14 @@ | |||
| protected int comments; | |||
| @SkipFromToString | |||
| protected String body; | |||
| // for backward compatibility with < 1.63, this collection needs to hold instances of Label, not GHLabel | |||
There was a problem hiding this comment.
v1.63 is 5 years ago.
| * | ||
| * @deprecated use {@link GHLabel} | ||
| */ | ||
| public static class Label extends GHLabel { |
There was a problem hiding this comment.
This is publicly visible, but not returned from any properties. It exists in one spot (above).
| pageSize); | ||
| } catch (MalformedURLException e) { | ||
| throw new GHException("Unable to build GitHub API URL", e); | ||
| return () -> { |
There was a problem hiding this comment.
Clean up to use even more of the existing code base. Still behaves the same.
| public String getGravatarId() { | ||
| return gravatar_id; | ||
| return ""; |
There was a problem hiding this comment.
This always returns "" anyway. So, let's be explicit about it.
| * | ||
| * @return the avatar url | ||
| */ | ||
| public String getAvatarUrl() { | ||
| if (avatar_url != null) |
There was a problem hiding this comment.
If this is null, it is still more meaningful that the "" returned from gravatar.
| return (HttpURLConnection) url.openConnection(p); | ||
| } | ||
| })); | ||
| return withConnector(new ImpatientHttpConnector(url -> (HttpURLConnection) url.openConnection(p))); |
There was a problem hiding this comment.
Found a way to do this without dynamic classes.
| // both thread an unread are included | ||
| // assertThat(t.getLastReadAt(), notNullValue()); | ||
| // assertThat(t.isRead(), equalTo(true)); |
There was a problem hiding this comment.
Are these commented out intentionally?
There was a problem hiding this comment.
Yes, I meant this as a note to say, "This query doesn't return only records where isRead() is true."
| * @return the string | ||
| * @deprecated Typo of {@link #getHttpTransportUrl()} | ||
| */ | ||
| public String gitHttpTransportUrl() { |
There was a problem hiding this comment.
It took me a few eye blinks to see this 💯
Co-Authored-By: Karl Shultz <[email protected]>
Description
There were a few very old deprecated classes that were annoying me. Like 3+ years deprecated.
Removed in this PR:
DeleteTokenGHIssue.LabelBefore submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.