[#714]Fix query parameter construction of org member filter #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
requested changes
Feb 25, 2020
There was a problem hiding this comment.
@Sage-Pierce
This looks really good. Minor additions needed.
| public void testListMembersWithRole() throws IOException { | ||
| GHOrganization org = gitHub.getOrganization(GITHUB_API_TEST_ORG); | ||
|
|
||
| List<GHUser> admins = org.listMembersWithRole("admin").asList(); |
There was a problem hiding this comment.
The bug was for listMembersWithFilter. Can you add a test for that as well?
|
|
||
| List<GHUser> admins = org.listMembersWithRole("admin").asList(); | ||
|
|
||
| assertFalse(admins.isEmpty()); |
There was a problem hiding this comment.
Go ahead and be specific about size and who is in the list. A check for non-empty list is not going to be enough to ensure this doesn't break in the future.
bitwiseman
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking a stab at what's mentioned in #714
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.