-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to specify permissions for collaborators #675
Added ability to specify permissions for collaborators #675
Conversation
Running mvn formatter:format refuses to format the file |
Hm, not sure why the formatting isn't happening. Have you tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission.
Good start (now that I can see the change. :)
We'll need tests for these new methods as well.
@jimmysombrero |
I was working in Windows, but switched to my Mac, which fixed the formatting issues I was having. My weekend project for this weekend is to add the missing methods back and write tests for the new methods. I was trying to wrap my head around how the json configuration files for WireMock are created then decided to follow the instructions in CONTRIBUTING.md and see what happens. |
If following the CONTRIBUTING doesn't basically "just work", I'm committed to fixing it. That's what it's there for. 😄 |
added tests for addCollaborators()
…mbrero/github-api into collaborator-permissions
Mark old addCollaborators methods depricated
…mbrero/github-api into collaborator-permissions
…mbrero/github-api into collaborator-permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test.
I realize I've given another round of suggestions/questions - I don't like making people go around more than once.
Now that we have a test, if you don't have time to address my comment, I'm willing to finish this PR up. It is up to you.
updated javadoc comments for addCollaborators methods combined both modifyCollaborators methods into one method updated addColloaborators test to match new method signature
Modified the addCollaborators methods to require a GHOrganization.Permission parameter in order allow the API to add external collaborators with varying levels of permissions. Added a second modifyCollaborators method with a signature that accepts a GHOrganization.Permission parameter.