Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createTag() method to GHRepository #651

Merged
merged 10 commits into from
Jan 18, 2020
Merged

Add createTag() method to GHRepository #651

merged 10 commits into from
Jan 18, 2020

Conversation

martinvanzijl
Copy link
Contributor

@martinvanzijl martinvanzijl commented Dec 22, 2019 •
edited
Loading

Description

Adds the createTag() method to GHRepository. Fixes #500.

Possible further enhancements are:

  • Add unit tests for tagging a "tree" and "blob".
  • Add versions of the method which take GHCommit, GHBlob or GHTree instead of the object and type parameters.
  • Add a version of the method which takes parameters for the tagger (name, email and date). This is optional, though, and seems to default to the user's credentials.
  • Add a GHCommit.createTag() method.

martinvanzijl and others added 3 commits December 23, 2019 05:43
@martinvanzijl
Add createTag() method.
998bda9 
Fixes hub4j#500.
@martinvanzijl
Deleted unit test cleanup method.
959eb46 
This method failed in the automated GitHub build online with a null
pointer exception.

I tried to make it a @Before/@after method, but that fails on
my local PC.
@bitwiseman
Merge branch 'master' into issue_500_create_tag_method
5709be7
@bitwiseman
Copy link
Member

@martinvanzijl
Looks like a test failed. Otherwise this change looks good.

@martinvanzijl
Copy link
Contributor Author

martinvanzijl commented Jan 10, 2020 •
edited
Loading

@bitwiseman Thanks, I had trouble getting the clean-up method to work in GHRepositoryTest, so I moved the test case to it's own class (GHTagTest). Looks like it's working on my PC. Let's see how it does in the automated CI Build and Test.

@martinvanzijl

This comment has been minimized.

Sign in to view
@martinvanzijl

This comment has been minimized.

Sign in to view
@martinvanzijl

This comment has been minimized.

Sign in to view
@martinvanzijl
Copy link
Contributor Author

Looks like it's working OK now!

@bitwiseman bitwiseman merged commit 30c70bc into hub4j:master Jan 18, 2020
@martinvanzijl martinvanzijl deleted the issue_500_create_tag_method branch January 20, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Create Tags method
2 participants
@martinvanzijl @bitwiseman