Contents API #59
Merged
Contents API #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kohsuke Kawaguchi » github-api #115 SUCCESS |
|
Thanks for creating this pull request @farmdawgnation! |
The create and update API calls don't send back the content you just sent, so that field is null. If this GHContent was instantiated from one of those calls, we want to make sure we can retrieve the content (and updated sha, etc) on the fly.
|
Kohsuke Kawaguchi » github-api #116 SUCCESS |
|
Kohsuke Kawaguchi » github-api #117 SUCCESS |
|
Ok, I think we're at the point where adding any more would be venturing outside the scope of just the contents api, so I think this one is ready for review/merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hat tip to @acollign for the work that he did on this to start. I took what he did and essentially added the ability to mutate content using the content API. This still needs some tests added, I think, but I had issues getting them to run? (I think something was screwy with my network connection?)
Anyway, I'm more than happy to add the tests, but I wanted to go ahead and start getting feedback on how this looks. :-)
This would resolve #46