-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue events API #479
Add issue events API #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! This looks reasonable to me. Can you add some tests?
…zijl/github-api into issue_376_issue_events
…zijl/github-api into issue_376_issue_events
- Created separate class for GHIssueEvent instead of nested classes. - Renamed test class accordingly. Other fixes: - Changed id type to long. - Updated test cases. - Added toString() method.
I've uploaded my latest progress. I want to make the unit tests more robust by creating an issue within the test itself, editing it and making sure the appropriate events are created. I also want to test the fields of the |
Cool just tell me when you're ready for review. |
@bitwiseman |
Fix for issue #376 (add issue events API).
Added the following methods: