Fixed OAuth connection to enterprise API #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaSha
reviewed
Oct 24, 2017
| @@ -178,6 +178,10 @@ public static GitHub connectToEnterprise(String apiUrl, String oauthAccessToken) | |||
| return new GitHubBuilder().withEndpoint(apiUrl).withOAuthToken(oauthAccessToken).build(); | |||
| } | |||
|
|
|||
| public static GitHub connectToEnterpriseWtihOAuth(String apiUrl, String login, String oauthAccessToken) throws IOException { | |||
|
Why you can't call Builder directly and build with arguments that you need? |
|
That is what have done as a work around, but I figured I would raise this change and see if anyone else has had this problem. @KostyaSha if this is not a common problem, then I will close this PR and continue using my own workaround. |
kohsuke
added a commit
that referenced
this pull request
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that the change to OAuth was made a long time ago. I just started using this library at work, and we use GitHub Enterprise.
When connecting with OAuth, I was getting a failure on the connection when using
GitHub.connectToEnterprise(apiUrl, oauthAccessToken)I noticed that there was no option to use login. I thought this was strange and tried to get to the bottom of it.The reason I have proposed the fix in this way was so that I didn't break the existing functionality (I don't think it was functioning as intended, but if it has gone this long without fixing I have to assume it is working for someone). That is why I didn't touch the existing method.
I am new to this project, so if there is more that I need to do for this to meet your requirements, please let me know.