Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add portion of auth/application API. #307

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Add portion of auth/application API. #307

merged 2 commits into from
Nov 11, 2016

Conversation

KostyaSha
Copy link
Contributor

@KostyaSha KostyaSha commented Nov 9, 2016 •
edited
Loading

This change is Reviewable

@KostyaSha
Add portion of auth/application API.
0aef9cc 
Signed-off-by: Kanstantsin Shautsou <[email protected]>
@KostyaSha
Copy link
Contributor Author

@stephenc @oleg-nenashev

@stephenc
Copy link
Contributor

stephenc commented Nov 9, 2016

👍

oleg-nenashev
oleg-nenashev approved these changes Nov 9, 2016
View reviewed changes
Copy link
Collaborator

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KostyaSha
KostyaSha commented Nov 9, 2016
View reviewed changes
src/main/java/org/kohsuke/github/GitHub.java
}

/**
* @see <a href="https://developer.github.com/v3/oauth_authorizations/#check-an-authorization">Check an authorization</a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste, will fix

@KostyaSha
Copy link
Contributor Author

Now fine

@KostyaSha
Copy link
Contributor Author

So merge and release?

@oleg-nenashev oleg-nenashev merged commit 24f48f6 into hub4j:master Nov 11, 2016
@KostyaSha
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KostyaSha @stephenc @oleg-nenashev