Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#269] Add reopen method on GHMilestone #270

Merged
merged 1 commit into from
Apr 13, 2016
Merged

[#269] Add reopen method on GHMilestone #270

merged 1 commit into from
Apr 13, 2016

Conversation

szpak
Copy link
Contributor

@szpak szpak commented Apr 4, 2016

Fixes #269.

@szpak szpak force-pushed the issue/269-reopenMilestone branch from dce045a to ce14046 Compare April 4, 2016 15:55
@szpak
Copy link
Contributor Author

szpak commented Apr 4, 2016

I'm not sure about the method name. open might suggest create a new milestone (like in "open a new issue"). On the other hand reopen is less consistent.

@kohsuke kohsuke merged commit b750707 into hub4j:master Apr 13, 2016
@szpak szpak deleted the issue/269-reopenMilestone branch April 14, 2016 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szpak @kohsuke