Make sure we return an empty list when no reviews #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't reproduce the problem described in hub4j#1768 but I thought we could add a test anyway as it doesn't cost us much.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
============================================
- Coverage 80.69% 80.66% -0.03%
- Complexity 2332 2342 +10
============================================
Files 220 220
Lines 7050 7082 +32
Branches 373 379 +6
============================================
+ Hits 5689 5713 +24
- Misses 1128 1132 +4
- Partials 233 237 +4 ☔ View full report in Codecov by Sentry. |
bitwiseman
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't reproduce the problem described in #1768 but I thought we could add a test anyway as it doesn't cost us much.