Only try to strip upload url 'helpful garbage' if it is present #1799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is mostly compatible with the Gitea API, which although somewhat incidental, is nonetheless wonderful. However, it fails to upload release assets due to this one small and easily-fixed issue. Adding this check does not in any way obstruct the normal use of the GitHub API.
Description
The GHRelease.uploadAsset method substrings the upload URL to grab the URL before the 'helpful garbage' provided by GitHub, which begins with a '{' character. However, if the upload URL does not have a '{' character in it for some reason (such as the API actually being provided by Gitea, not GitHub), this method throws an exception. This change simply adds a check to avoid this exception.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: