-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suspended Installation Properties to GHAppInstallation #1780
Add Suspended Installation Properties to GHAppInstallation #1780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These properties are represented in the current test data, but they are always null
. To record examples of suspended installations, it's my understanding that a test would need to suspend an installation on the hub4j-test-org, and doing so requires admin level access to the org. This sounds prohibitively difficult to contribute. Please advise if there's a good way to test these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could manually add test datafiles or I can grant you admin access to the org, whichever you would rather do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the tests and test files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that adding tests for fields like these is difficult, but they need to be covered. If they aren't a future change could silent break this functionality.
cfb3182
to
bfcd88f
Compare
1ae2653
to
d9a5602
Compare
A suspended app installation has suspended_at and suspended_by properties that were missing from the GHAppInstallation class.
d9a5602
to
a022756
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1780 +/- ##
=========================================
Coverage 80.69% 80.69%
- Complexity 2330 2332 +2
=========================================
Files 220 220
Lines 7049 7051 +2
Branches 372 372
=========================================
+ Hits 5688 5690 +2
Misses 1128 1128
Partials 233 233 ☔ View full report in Codecov by Sentry. |
Description
A suspended app installation has
suspended_at
andsuspended_by
properties that were missing from theGHAppInstallation
class.https://docs.github.com/en/rest/apps/apps?apiVersion=2022-11-28#list-installations-for-the-authenticated-app