-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return all files from a commit #1679
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
============================================
+ Coverage 80.02% 80.04% +0.02%
- Complexity 2224 2231 +7
============================================
Files 213 215 +2
Lines 6733 6760 +27
Branches 365 365
============================================
+ Hits 5388 5411 +23
- Misses 1131 1134 +3
- Partials 214 215 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically all one big change suggestion to make listFiles()
return a PagedIterable
.
Other than that, this PR looks great! Well tested.
@bitwiseman I've made the suggested changes, let me know how it looks now. Thanks |
Description
Fixes #1669
If there are more than 300 files in the commit diff, the GitHub API response will include pagination link headers for the remaining files, up to a limit of 3000 files. Each page contains the static commit information, and the only changes are to the file listing. This PR adds
GHCommit.listFiles()
which returns the list of files in a commit via paginated responses. It deprecates the previous method to get the files:GHCommit.getFiles()
.The PR also populates the
message
in aGHCommit
which was previously null.Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: