-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generify OrgAppInstallationAuthorizationProvider to support any kind of app lookup. #1624
Generify OrgAppInstallationAuthorizationProvider to support any kind of app lookup. #1624
Conversation
Thanks to @PierreBtz for his pull request hub4j/github-api#1624.
@PierreBtz I've invited you to the |
@bitwiseman thanks for the access. I finally had time to complete this work... |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
=========================================
Coverage 79.89% 79.89%
Complexity 2197 2197
=========================================
Files 209 210 +1
Lines 6670 6671 +1
Branches 364 364
=========================================
+ Hits 5329 5330 +1
Misses 1127 1127
Partials 214 214
☔ View full report in Codecov by Sentry. |
@bitwiseman gentle ping, is there anything blocking this PR from being merged? Thanks for your time. |
@bitwiseman thanks for taking care of the merge, would you mind cutting a release ? |
@PierreBtz |
Thanks!! |
Description
The
OrgAppInstallationAuthorizationProvider
only works with organization level apps, leaving out user apps. The bulk of the class logic remains useful to perform application lookup other ways (eg using the installation id), or even to lookup for user application.This PR provides a way for the API user to provide its own lookup logic.
This PR is submitted as a draft because:
hub4j-test-org
as well as the installation id of the test app to finish writing the tests.OrgAppInstallationAuthorizationProvider
should be deprecated. The way I see it, it's not useless and just a maintenance burden that you might want to remove in the future after a deprecation phase :)Before submitting a PR:
mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR:
[ ] If this PR fixes one or more issues, include "Fixes #" lines for each issue.[ ] Provide links to relevant documentation on https://docs.github.com/en/rest where possible.