Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1597: Add deliberately broken CODEOWNERS file #1604

Conversation

michael-s-grant
Copy link
Contributor

Description

Fixes #1579: Added CODEOWNERS file with a eliberate error to test response to repo.listCodeownersErrors().

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@michael-s-grant michael-s-grant changed the title Feature/issue 1597 add list codeowners errors Issue #1597: Add deliberately broken CODEOWNERS file Jan 26, 2023
… of deprecated GitHub action `set-output`, which will cease functioning altogether at the end of May.
…wnersErrors' into feature/issue-1597-add-listCodeownersErrors

# Conflicts:
#	.github/workflows/maven.yml
…g to solve a problem (the use of the deprecated `set-output`) seen in the logs from my previous run, but which I think was already solved through use of maven-build.yml.
@bitwiseman bitwiseman merged commit 54d60fb into hub4j:main Jan 27, 2023
@michael-s-grant michael-s-grant deleted the feature/issue-1597-add-listCodeownersErrors branch January 30, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants