Add logs in GitHubClient response. fixes #1594 #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.31% // Head: 79.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
============================================
- Coverage 79.31% 79.22% -0.09%
- Complexity 2140 2141 +1
============================================
Files 206 206
Lines 6565 6576 +11
Branches 362 364 +2
============================================
+ Hits 5207 5210 +3
- Misses 1146 1154 +8
Partials 212 212
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bitwiseman
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
@c3p0-maif
We generally require tests coverage of new code. In this case, there's no test covering the existing code... But there are tests that use lockers to check the output of certain actions. Would you be willing to write a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a log in order to debug the GitHub response.
I add the hash of the request to the begginning of the log, in order to identify which response corresponds to which request.