Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #1307

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Code cleanup #1307

merged 1 commit into from
Nov 20, 2021

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #1307 (cba827d) into main (e403ce4) will increase coverage by 0.11%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1307      +/-   ##
============================================
+ Coverage     77.86%   77.97%   +0.11%     
- Complexity     2009     2013       +4     
============================================
  Files           197      198       +1     
  Lines          6215     6210       -5     
  Branches        359      355       -4     
============================================
+ Hits           4839     4842       +3     
+ Misses         1162     1159       -3     
+ Partials        214      209       -5     
Impacted Files Coverage Δ
.../main/java/org/kohsuke/github/AbstractBuilder.java 77.77% <ø> (ø)
...ain/java/org/kohsuke/github/AbuseLimitHandler.java 78.94% <ø> (ø)
src/main/java/org/kohsuke/github/GHRateLimit.java 88.05% <ø> (ø)
...va/org/kohsuke/github/GitHubAbuseLimitHandler.java 100.00% <ø> (ø)
src/main/java/org/kohsuke/github/GitHubClient.java 90.36% <ø> (ø)
...ke/github/GitHubConnectorResponseErrorHandler.java 100.00% <ø> (ø)
...va/org/kohsuke/github/GitHubInteractiveObject.java 100.00% <ø> (ø)
...org/kohsuke/github/GitHubPageContentsIterable.java 100.00% <ø> (ø)
...in/java/org/kohsuke/github/GitHubPageIterator.java 83.67% <ø> (ø)
...ava/org/kohsuke/github/GitHubRateLimitChecker.java 75.00% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e403ce4...cba827d. Read the comment docs.

@bitwiseman bitwiseman merged commit bc13252 into hub4j:main Nov 20, 2021
@bitwiseman bitwiseman deleted the task/urlcleanup branch November 20, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant