Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub event branch_protection_rule #1301

Merged

Conversation

gjabouley-invn
Copy link
Contributor

Description

Add support for GitHub event branch_protection_rule
Fixes #1297
Note i had a first look at GHEventPayload.java but i don't know how to fully add the payload for this event (seems it also needs a new event class)

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@bitwiseman
Copy link
Member

@gjabouley-invn

Note i had a first look at GHEventPayload.java but i don't know how to fully add the payload for this event (seems it also needs a new event class)

Could you talk a bit more about what you mean here? Each payload gets a new nested class inside GHEventPayload. What other "new event" would be needed?

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1301 (702833e) into main (d46bca7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1301   +/-   ##
=========================================
  Coverage     77.89%   77.89%           
  Complexity     2012     2012           
=========================================
  Files           197      197           
  Lines          6219     6220    +1     
  Branches        359      359           
=========================================
+ Hits           4844     4845    +1     
  Misses         1161     1161           
  Partials        214      214           
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHEvent.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46bca7...702833e. Read the comment docs.

@bitwiseman bitwiseman merged commit c83fcec into hub4j:main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHEvent enum is missing branch_protection_rule
2 participants