Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage to Java 11 #1299

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Move coverage to Java 11 #1299

merged 3 commits into from
Nov 17, 2021

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1299 (ccf8685) into main (50d4ae6) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1299      +/-   ##
============================================
- Coverage     77.89%   77.86%   -0.04%     
  Complexity     2011     2011              
============================================
  Files           197      197              
  Lines          6217     6220       +3     
  Branches        358      362       +4     
============================================
  Hits           4843     4843              
  Misses         1160     1160              
- Partials        214      217       +3     
Impacted Files Coverage Δ
...ava/org/kohsuke/github/GitHubRateLimitChecker.java 69.23% <0.00%> (-5.77%) ⬇️
src/main/java/org/kohsuke/github/GHRepository.java 68.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d4ae6...ccf8685. Read the comment docs.

@bitwiseman bitwiseman merged commit aad8b9a into hub4j:main Nov 17, 2021
@bitwiseman bitwiseman deleted the task/java11 branch November 17, 2021 16:36
bitwiseman added a commit to bitwiseman/github-api that referenced this pull request Nov 19, 2021
This reverts commit aad8b9a, reversing
changes made to 50d4ae6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant