Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Site CI check" #1268

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Oct 21, 2021

This reverts commit e317813.

Fixes #1229

Description

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1268 (4c60ee5) into main (cbd89d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1268   +/-   ##
=========================================
  Coverage     77.50%   77.50%           
  Complexity     1905     1905           
=========================================
  Files           189      189           
  Lines          6000     6000           
  Branches        328      328           
=========================================
  Hits           4650     4650           
  Misses         1150     1150           
  Partials        200      200           
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHRepository.java 68.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd89d7...4c60ee5. Read the comment docs.

@bitwiseman bitwiseman merged commit 18f9ca9 into hub4j:main Oct 21, 2021
@bitwiseman bitwiseman deleted the activate-site branch October 21, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven site failing in CI, passing in local build
1 participant