Support getting repository from project card #1260
Conversation
|
Blocked by #1261 |
| @@ -55,6 +55,8 @@ public void testCreateCardFromIssue() throws IOException { | |||
| GHIssue issue = repo.createIssue("new-issue").body("With body").create(); | |||
| GHProjectCard card = column.createCard(issue); | |||
| assertThat(card.getContentUrl(), equalTo(issue.getUrl())); | |||
| assertThat(card.getContent(), notNullValue()); | |||
| assertThat(card.getContent().getRepository(), notNullValue()); | |||
There was a problem hiding this comment.
This needs to assert some meaningful information, such as Id and/or description. Just notNullValue() is not a sufficient test.
There was a problem hiding this comment.
Agreed, this was just to get the right API calls being made.
Signed-off-by: Jonathan Leitschuh <[email protected]>
JLLeitschuh
force-pushed
the
fix/JLL/project_card_repository
branch
from
19e9a95 to
1cdbc17
Compare
Codecov Report
@@ Coverage Diff @@
## main #1260 +/- ##
============================================
+ Coverage 77.47% 77.50% +0.02%
- Complexity 1901 1905 +4
============================================
Files 189 189
Lines 5985 6000 +15
Branches 327 328 +1
============================================
+ Hits 4637 4650 +13
Misses 1150 1150
- Partials 198 200 +2
Continue to review full report at Codecov.
|
Co-authored-by: Liam Newman <[email protected]>
JLLeitschuh
force-pushed
the
fix/JLL/project_card_repository
branch
from
8ad4369 to
0c71293
Compare
|
Hey @bitwiseman, I'm currently participating in Hacktoberfest. If you think this PR was useful, would you be so kind as to add the |
Closes #1097
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
main. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: