Using TCK Tested JDK builds of OpenJDK #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. As good practice I added major fixed versions of JDK 8.0.192, 11.0.3. An example is when 8.0.192 passes(green) and 8 (latest) fails (red) you know it was the build version not your code that caused the build to fail. While Temurin is the successor to AdoptOpenJDK it does not support archived versions prior to sept. 2021. Azul has all archived versions and the latest releases.
Codecov Report
@@ Coverage Diff @@
## main #1242 +/- ##
=========================================
Coverage 77.45% 77.45%
Complexity 1900 1900
=========================================
Files 189 189
Lines 5979 5979
Branches 327 327
=========================================
Hits 4631 4631
Misses 1150 1150
Partials 198 198 Continue to review full report at Codecov.
|
|
I have to look as to why the fixed version for JDK 8.0.192) fails in testing. |
The option --add-opens does not exist in 8.0.192 and testing on 8.0.202.
Discovered --add-opens doesn't exist in JDK 8 and logic avoids applying the JVM switch.
|
The workflow is all green on my branch 👍🏼. I noticed the logic in the workflow on when to use the
The logic will now avoid applying the JVM option to JDK 8 versions (even fixed versions). |
|
Thank you. Glad to have helped contribute! |
bitwiseman
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu
you get all the latest updated (TCK Tested) builds for all versions of OpenJDK.
As good practice I added major fixed versions of JDK 8.0.192, 11.0.3.
An example is when 8.0.192 passes(green) and 8 (latest) fails (red) you know it was the build version not your code that caused the build to fail.
While Temurin is the successor to AdoptOpenJDK it does not support archived versions prior to sept. 2021. Azul has all archived versions and the latest releases.