Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Malformed URL catching to core #1241

Merged
merged 2 commits into from
Sep 26, 2021
Merged

Conversation

bitwiseman
Copy link
Member

Description

This MalformedURLException is always caught and re-thrown as GHException.
Converting that to be the standard behavior.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1241 (58099fc) into main (c0d8059) will increase coverage by 0.32%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1241      +/-   ##
============================================
+ Coverage     76.96%   77.28%   +0.32%     
- Complexity     1888     1889       +1     
============================================
  Files           188      188              
  Lines          5968     5943      -25     
  Branches        328      328              
============================================
  Hits           4593     4593              
+ Misses         1176     1152      -24     
+ Partials        199      198       -1     
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHPerson.java 66.66% <0.00%> (+3.03%) ⬆️
src/main/java/org/kohsuke/github/GHCompare.java 91.93% <80.00%> (+2.87%) ⬆️
...ain/java/org/kohsuke/github/GHAppInstallation.java 91.89% <100.00%> (+4.39%) ⬆️
...org/kohsuke/github/GHAppInstallationsIterable.java 100.00% <100.00%> (+14.28%) ⬆️
...n/java/org/kohsuke/github/GHArtifactsIterable.java 91.66% <100.00%> (+11.66%) ⬆️
.../main/java/org/kohsuke/github/GHSearchBuilder.java 100.00% <100.00%> (+16.66%) ⬆️
.../org/kohsuke/github/GHWorkflowJobQueryBuilder.java 100.00% <100.00%> (+18.18%) ⬆️
...ava/org/kohsuke/github/GHWorkflowRunsIterable.java 100.00% <100.00%> (+13.33%) ⬆️
...n/java/org/kohsuke/github/GHWorkflowsIterable.java 93.33% <100.00%> (+10.00%) ⬆️
...in/java/org/kohsuke/github/GitHubPageIterator.java 83.67% <100.00%> (+3.28%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d8059...58099fc. Read the comment docs.

@bitwiseman bitwiseman force-pushed the malformed-url branch 2 times, most recently from ad58f02 to 1e813bf Compare September 26, 2021 06:19
@bitwiseman bitwiseman merged commit 2dc736a into hub4j:main Sep 26, 2021
@bitwiseman bitwiseman deleted the malformed-url branch September 26, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant