-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added list-workflow-runs
API
#1240
Added list-workflow-runs
API
#1240
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1240 +/- ##
============================================
+ Coverage 76.93% 76.96% +0.02%
- Complexity 1887 1888 +1
============================================
Files 188 188
Lines 5966 5968 +2
Branches 328 328
============================================
+ Hits 4590 4593 +3
Misses 1176 1176
+ Partials 200 199 -1
Continue to review full report at Codecov.
|
@@ -18,6 +19,15 @@ public GHWorkflowRunsIterable(GHRepository owner, GitHubRequest request) { | |||
this.request = request; | |||
} | |||
|
|||
public GHWorkflowRunsIterable(GHRepository owner, GitHubRequest.Builder<?> requestBuilder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this method call this constructor and remove the other constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested.
Other than that looks great!
7c52405
to
4d14405
Compare
Hi @bitwiseman, when new version ( |
Description
Add
list-workflow-runs
API support (https://docs.github.com/en/rest/reference/actions#list-workflow-runs) to theGHWorkflow
.