Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list-workflow-runs API #1240

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

serkan-ozal
Copy link
Contributor

Description

Add list-workflow-runs API support (https://docs.github.com/en/rest/reference/actions#list-workflow-runs) to the GHWorkflow.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1240 (4d14405) into main (dae92fc) will increase coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1240      +/-   ##
============================================
+ Coverage     76.93%   76.96%   +0.02%     
- Complexity     1887     1888       +1     
============================================
  Files           188      188              
  Lines          5966     5968       +2     
  Branches        328      328              
============================================
+ Hits           4590     4593       +3     
  Misses         1176     1176              
+ Partials        200      199       -1     
Impacted Files Coverage Δ
...c/main/java/org/kohsuke/github/GHOrganization.java 64.74% <ø> (ø)
...ava/org/kohsuke/github/GHWorkflowRunsIterable.java 86.66% <60.00%> (-5.00%) ⬇️
src/main/java/org/kohsuke/github/GHWorkflow.java 89.28% <100.00%> (+0.39%) ⬆️
.../org/kohsuke/github/GHWorkflowRunQueryBuilder.java 62.50% <100.00%> (+6.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae92fc...4d14405. Read the comment docs.

@@ -18,6 +19,15 @@ public GHWorkflowRunsIterable(GHRepository owner, GitHubRequest request) {
this.request = request;
}

public GHWorkflowRunsIterable(GHRepository owner, GitHubRequest.Builder<?> requestBuilder) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this method call this constructor and remove the other constructor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested.

Other than that looks great!

@serkan-ozal serkan-ozal force-pushed the improvement/workflow/list-runs branch from 7c52405 to 4d14405 Compare September 25, 2021 05:42
@bitwiseman bitwiseman merged commit c0d8059 into hub4j:main Sep 25, 2021
@serkan-ozal
Copy link
Contributor Author

Hi @bitwiseman, when new version (1.134) will be released?

@serkan-ozal serkan-ozal deleted the improvement/workflow/list-runs branch September 26, 2021 06:27
@bitwiseman bitwiseman mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants