Add delete webhook via id functionality. #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1237 +/- ##
============================================
+ Coverage 76.90% 76.92% +0.02%
- Complexity 1885 1887 +2
============================================
Files 188 188
Lines 5958 5964 +6
Branches 328 328
============================================
+ Hits 4582 4588 +6
Misses 1176 1176
Partials 200 200
Continue to review full report at Codecov.
|
bitwiseman
reviewed
Sep 24, 2021
| @@ -653,7 +653,7 @@ public void tryHook() throws Exception { | |||
| assertThat(hook2.getConfig().size(), equalTo(3)); | |||
| assertThat(hook2.isActive(), equalTo(true)); | |||
| hook2.ping(); | |||
| hook2.delete(); | |||
There was a problem hiding this comment.
We still need to test both pathways of hook2.delete().
bitwiseman
force-pushed
the
feature/#1231
branch
from
f3b193e to
1e580da
Compare
|
@bloslo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add delete webhook via id functionality. Closes #1231