Streamline GitHub root handling #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
force-pushed
the
task/cleanup-root
branch
from
7ff3db1 to
29b01f6
Compare
Codecov Report
@@ Coverage Diff @@
## main #1230 +/- ##
============================================
+ Coverage 75.45% 76.90% +1.44%
+ Complexity 1910 1885 -25
============================================
Files 188 188
Lines 6201 5958 -243
Branches 369 328 -41
============================================
- Hits 4679 4582 -97
+ Misses 1301 1176 -125
+ Partials 221 200 -21
Continue to review full report at Codecov.
|
bitwiseman
force-pushed
the
task/cleanup-root
branch
3 times, most recently
from
b2bcced to
d864757
Compare
bitwiseman
force-pushed
the
task/cleanup-root
branch
from
d864757 to
cfcf81a
Compare
bitwiseman
commented
Sep 11, 2021
bitwiseman
force-pushed
the
task/cleanup-root
branch
from
796214c to
2a495ab
Compare
bitwiseman
force-pushed
the
task/cleanup-root
branch
5 times, most recently
from
d9cb1bf to
d099220
Compare
bitwiseman
force-pushed
the
task/cleanup-root
branch
2 times, most recently
from
88ef76d to
22cfb00
Compare
bitwiseman
force-pushed
the
task/cleanup-root
branch
from
22cfb00 to
0467f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Streamline GitHub root handling.
Making this work required change to
GHMyselfand howGitHubandGitHubClientget login strings.I also added tests to cover a number of missing code paths to continue to bring coverage numbers up.