Use custom HttpConnector when authentication #120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to modify ghprb-plugin so that it can work behind authentication proxies.
I added a HttpConnector implementation to ghprb-plugin:
Since all
GitHub
constructors areprivate
, there is no way to call#setConnector
beforeGitHub(String, String, Sttring, String)
constructor calls#getMyself
, nor to extendGitHub
class.So I added
HttpConnector
parameter toconnect*
methods, exceptconnectToEnterprise
which does not require proxies in most cases.