Add ability to search repos by fork and visibility #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
============================================
+ Coverage 74.16% 74.25% +0.09%
- Complexity 1874 1880 +6
============================================
Files 188 188
Lines 6182 6200 +18
Branches 368 368
============================================
+ Hits 4585 4604 +19
+ Misses 1375 1374 -1
Partials 222 222
Continue to review full report at Codecov.
|
t0m4uk1991
force-pushed
the
repo_search_by_fork_and_visibility
branch
from
c2ae62e to
622017a
Compare
…|private|internal)
t0m4uk1991
force-pushed
the
repo_search_by_fork_and_visibility
branch
from
622017a to
2c323d2
Compare
bitwiseman
reviewed
Jun 25, 2021
src/main/java/org/kohsuke/github/GHRepositorySearchBuilder.java
Outdated
Show resolved
Hide resolved
bitwiseman
reviewed
Jun 25, 2021
bitwiseman
requested changes
Jun 25, 2021
…HRepositorySearchBuilder
|
Hi @bitwiseman |
|
@t0m4uk1991 If you disagree with the changes, please feel free to modify or revert them and we can discuss further. |
bitwiseman
force-pushed
the
repo_search_by_fork_and_visibility
branch
from
d7a19aa to
74b1977
Compare
Added javadoc for each value of Fork search mode enum. Made passing UNKNOWN to visibility() throw a GHException. UNKNOWN a placeholder and should never be passed into any method in the API.
bitwiseman
force-pushed
the
repo_search_by_fork_and_visibility
branch
from
74b1977 to
1994f47
Compare
bitwiseman
approved these changes
Jul 6, 2021
|
@bitwiseman |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated GHRepositorySearchBuilder.java, add ability to search repos by fork:(true|only) and visibility:(public|private|internal)
This one issue #1174 should be closed after merge.
Fixes #1174