Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1083 reflective access for PATCH method #1164

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented May 27, 2021

Description

#1083 removed reflective access. However, some endpoints do not support X-HTTP-Method-Override. In the interest of stability over purity, I'm reverting this.

Reopens #754
Fixes #1157

@gsmet @hcoles

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@bitwiseman bitwiseman force-pushed the revert/reflective branch from 0869267 to 0295ad8 Compare May 27, 2021 18:35
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1164 (2436ed0) into main (196ee25) will decrease coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1164      +/-   ##
============================================
- Coverage     73.55%   73.43%   -0.13%     
  Complexity     1831     1831              
============================================
  Files           185      185              
  Lines          6127     6143      +16     
  Branches        365      367       +2     
============================================
+ Hits           4507     4511       +4     
- Misses         1400     1411      +11     
- Partials        220      221       +1     
Impacted Files Coverage Δ
.../kohsuke/github/GitHubHttpUrlConnectionClient.java 81.63% <33.33%> (-11.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196ee25...2436ed0. Read the comment docs.

@bitwiseman
Copy link
Member Author

Great. For Java 16, the reflection no longer works.

@gsmet
Copy link
Contributor

gsmet commented May 27, 2021

Yeah, that's expected.

If you're using JDK 16+, either you add a --add-opens or you use OkHttp. Until we have a client based on the new JDK 11+ HTTP client.

@bitwiseman bitwiseman force-pushed the revert/reflective branch from cbe8c68 to c2f9802 Compare May 27, 2021 21:35
@bitwiseman bitwiseman force-pushed the revert/reflective branch from c2f9802 to 2436ed0 Compare May 27, 2021 21:42
@bitwiseman
Copy link
Member Author

@gsmet @hcoles
The failures are due only to code coverage drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateCheckRun call fails since 1.128
2 participants