Remove a trailing slash from getWorkflowJob #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
approved these changes
May 27, 2021
bitwiseman
approved these changes
May 27, 2021
There was a problem hiding this comment.
@shuheiktgw
You'll need to update the test files to match this change. Otherwise looks great thanks!
|
@bitwiseman Sorry for not noticing the test! I've updated it so would you review the change again? |
Codecov Report
@@ Coverage Diff @@
## main #1158 +/- ##
=========================================
Coverage 73.55% 73.55%
Complexity 1831 1831
=========================================
Files 185 185
Lines 6127 6127
Branches 365 365
=========================================
Hits 4507 4507
Misses 1400 1400
Partials 220 220
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found the request URL looks like
https://api.github.com/repos/owner/repo/actions/jobs//xxxand the URL contains//betweenjobsand its id. I looked into it and found we need to remove a trailing slash from the getWorkflowJob method. Thank you for your review!Currently, the API returned 404 when we use the getWorkflowJob method so I'd really appreciate it if you would review and release this change soon.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
main. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: