Get all orgs/teams/permissions in a single GitHub API call #112
Conversation
|
Kohsuke Kawaguchi » github-api #208 SUCCESS |
|
Unfortunately I cannot really assert anything sure as different users may have different organisations and teams. I will never be sure on who is running the tests and on which user. |
|
@lucamilanesio I guess maybe try getting that info via a different method and verify if its the same |
|
Yes, I could ... but it is like measure a metre with the same metre 😃 But you're right: better than nothing 😸 |
Exposes a new API call at GitHub root level to build the complete set of organisations and teams that current user belongs to. This change allows to massively reduce the number of calls to GitHub especially for people that belongs to multiple organisations with lots of teams and members. Signed-off-by: Luca Milanesio <[email protected]>
|
Kohsuke Kawaguchi » github-api #209 SUCCESS |
|
@suryagaddipati what do you think now? Split into two separate tests, one on the organizations and another on the teams (one test = one thing = one assertion). |
|
@kohsuke @suryagaddipati any extra feedback on this change? Are we good to go? |
|
@kohsuke @suryagaddipati ping ? |
|
@lucamilanesio sorry. I will test this out this evening. |
|
@suryagaddipati thanks for that. Is the change OK now? Can we merge it? |
Get all orgs/teams/permissions in a single GitHub API call
|
@lucamilanesio merged it in and made a new release (1.57). |
|
@suryagaddipati fantastic, great news. Will refer to the new release in our GitHub plugin for Gerrit Code Review (https://gerrit-review.googlesource.com/#/admin/projects/plugins/github) |
|
@suryagaddipati I cannot find the github-api 1.57 in any public maven repo ... have you published it somewhere? |
Exposes a new API call at GitHub root level to build the complete
set of organisations and teams that current user belongs to.
This change allows to massively reduce the number of calls to GitHub
especially for people that belongs to multiple organisations with
lots of teams and members.
Signed-off-by: Luca Milanesio [email protected]