Allow JWT from string #1021
Merged
Allow JWT from string #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
commented
Jan 14, 2021
| @@ -42,11 +42,15 @@ | |||
| private final String applicationId; | |||
|
|
|||
| public JWTTokenProvider(String applicationId, File keyFile) throws GeneralSecurityException, IOException { | |||
| this(applicationId, loadPrivateKey(keyFile.toPath())); | |||
| this(applicationId, keyFile.toPath()); | |||
There was a problem hiding this comment.
Refactoring to get a single code path through all the constructors.
bitwiseman
commented
Jan 14, 2021
| @@ -34,9 +36,12 @@ | |||
| JWT_PROVIDER_1 = new JWTTokenProvider(TEST_APP_ID_1, | |||
| new File(this.getClass().getResource(PRIVATE_KEY_FILE_APP_1).getFile())); | |||
| JWT_PROVIDER_2 = new JWTTokenProvider(TEST_APP_ID_2, | |||
| new File(this.getClass().getResource(PRIVATE_KEY_FILE_APP_2).getFile())); | |||
| new File(this.getClass().getResource(PRIVATE_KEY_FILE_APP_2).getFile()).toPath()); | |||
There was a problem hiding this comment.
Modified tests to make sure all constructors are tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: