You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue:
When requesting data about a single branch via the github-api, if it gets a 404 or nothing back from the branch it will return a null value for the branch rather than throwing an error.
Steps to reproduce: (did this while mocking a github response)
Request a single branch by name
Fake a returned json for a 200(branch does not exist)
Observe that the github-api returns instead a null value
Expected result:
I would normally expect the github API to return a GHFileNotFound error rather than a null value since that is what happens if you make the same request for a tag or PR
The text was updated successfully, but these errors were encountered:
alexanderrtaylor
changed the title
When requesting a single branch and getting a 404 response it will return "null"
When requesting a single branch and getting a 200 response it will return "null"
Nov 14, 2019
bitwiseman
changed the title
When requesting a single branch and getting a 200 response it will return "null"
Requesting a branch and getting a 200 response with invalid JSON returns null
Nov 19, 2019
Issue:
When requesting data about a single branch via the github-api, if it gets a 404 or nothing back from the branch it will return a
null
value for the branch rather than throwing an error.Steps to reproduce: (did this while mocking a github response)
Expected result:
I would normally expect the github API to return a GHFileNotFound error rather than a null value since that is what happens if you make the same request for a tag or PR
The text was updated successfully, but these errors were encountered: