Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitHttpTransportUrl Rename #403

Closed
mhohmeier opened this issue Dec 6, 2017 · 0 comments
Closed

gitHttpTransportUrl Rename #403

mhohmeier opened this issue Dec 6, 2017 · 0 comments

Comments

@mhohmeier
Copy link

Just wanted to mention that in GHRepository in line 176, the method is named "gitHttpTransportUrl" which is quite confusing given the other methods are named like "getSvnUrl", "getGitTransportUrl" etc.
If this is just a typo, i would recommend adding "getHttpTransportUrl" since i looked quite some time for that method...
@mhohmeier mhohmeier changed the title gitHttpTransportUrl gitHttpTransportUrl Rename Dec 6, 2017
kohsuke added a commit that referenced this issue Jan 13, 2018
@kohsuke
Issue #403: Typo in method name
5113aac
@kohsuke kohsuke closed this as completed Jan 13, 2018
@jgournet jgournet mentioned this issue Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @mhohmeier