Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHContent.read() is broken due to incorrect HTTP Method #215

Closed
if6was9 opened this issue Sep 1, 2015 · 0 comments · Fixed by #216
Closed

GHContent.read() is broken due to incorrect HTTP Method #215

if6was9 opened this issue Sep 1, 2015 · 0 comments · Fixed by #216

Comments

@if6was9
Copy link

if6was9 commented Sep 1, 2015

GHContent.read() issues the request as POST rather than GET. This is fine for URLs that do not
require authentication. However, when download_url links are returned that have tokens in the query string, the corresponding POST fails.

Presumably it fails because on the remote end, the query string parameters of the POST request are not honored.

This issue would never be detected if testing happens against a public GitHub URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#215 fix read() failure with private repos
1 participant
@if6was9