Merge pull request #946 from seregamorph/feature/pull-request-review-…

…html-url pullRequestReview.review.htmlUrl
hub4j · Sep 25, 2020 · f1ca0b5 · f1ca0b5
2 parents 07a392c + 0894c80
commit f1ca0b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/org/kohsuke/github/GHPullRequestReview.java b/src/main/java/org/kohsuke/github/GHPullRequestReview.java
@@ -46,6 +46,7 @@ public class GHPullRequestReview extends GHObject {
     private String commit_id;
     private GHPullRequestReviewState state;
     private String submitted_at;
+    private String html_url;
 
     GHPullRequestReview wrapUp(GHPullRequest owner) {
         this.owner = owner;
@@ -102,7 +103,7 @@ public GHPullRequestReviewState getState() {
 
     @Override
     public URL getHtmlUrl() {
-        return null;
+        return GitHubClient.parseURL(html_url);
     }
 
     /**

diff --git a/src/test/java/org/kohsuke/github/GHEventPayloadTest.java b/src/test/java/org/kohsuke/github/GHEventPayloadTest.java
@@ -216,6 +216,8 @@ public void pull_request_review() throws Exception {
         assertThat(event.getPullRequest().getNumber(), is(8));
         assertThat(event.getPullRequest().getTitle(), is("Add a README description"));
         assertThat(event.getPullRequest().getBody(), is("Just a few more details"));
+        assertThat(event.getReview().getHtmlUrl(),
+                hasToString("https://github.com/baxterthehacker/public-repo/pull/8#pullrequestreview-2626884"));
         assertThat(event.getPullRequest().getUser().getLogin(), is("skalnik"));
         assertThat(event.getPullRequest().getHead().getUser().getLogin(), is("skalnik"));
         assertThat(event.getPullRequest().getHead().getRef(), is("patch-2"));