Add the node_id to the Discussion Category payload

I reported the fact that the field was missing to the GitHub team and they were kind enough to add it so we can now take it into account.
hub4j · Dec 1, 2021 · e59b438 · e59b438
1 parent 08bff69
commit e59b438
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/src/main/java/org/kohsuke/github/GHRepositoryDiscussion.java b/src/main/java/org/kohsuke/github/GHRepositoryDiscussion.java
@@ -113,6 +113,7 @@ public String getTimelineUrl() {
     public static class Category {
 
         private long id;
+        private String nodeId;
         private long repositoryId;
         private String emoji;
         private String name;
@@ -126,6 +127,10 @@ public long getId() {
             return id;
         }
 
+        public String getNodeId() {
+            return nodeId;
+        }
+
         public long getRepositoryId() {
             return repositoryId;
         }

diff --git a/src/test/java/org/kohsuke/github/GHEventPayloadTest.java b/src/test/java/org/kohsuke/github/GHEventPayloadTest.java
@@ -953,6 +953,7 @@ public void discussion_created() throws Exception {
         GHRepositoryDiscussion.Category category = discussion.getCategory();
 
         assertThat(category.getId(), is(33522033L));
+        assertThat(category.getNodeId(), is("DIC_kwDOEq3cwc4B_4Fx"));
         assertThat(category.getEmoji(), is(":pray:"));
         assertThat(category.getName(), is("Q&A"));
         assertThat(category.getDescription(), is("Ask the community for help"));
@@ -1000,6 +1001,7 @@ public void discussion_answered() throws Exception {
         GHRepositoryDiscussion.Category category = discussion.getCategory();
 
         assertThat(category.getId(), is(33522033L));
+        assertThat(category.getNodeId(), is("DIC_kwDOEq3cwc4B_4Fx"));
         assertThat(category.getEmoji(), is(":pray:"));
         assertThat(category.getName(), is("Q&A"));
         assertThat(category.getDescription(), is("Ask the community for help"));
@@ -1048,6 +1050,7 @@ public void discussion_labeled() throws Exception {
         GHRepositoryDiscussion.Category category = discussion.getCategory();
 
         assertThat(category.getId(), is(33522033L));
+        assertThat(category.getNodeId(), is("DIC_kwDOEq3cwc4B_4Fx"));
         assertThat(category.getEmoji(), is(":pray:"));
         assertThat(category.getName(), is("Q&A"));
         assertThat(category.getDescription(), is("Ask the community for help"));

diff --git a/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_answered.json b/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_answered.json
@@ -4,6 +4,7 @@
         "repository_url": "https://api.github.com/repos/gsmet/quarkus-bot-java-playground",
         "category": {
             "id": 33522033,
+            "node_id": "DIC_kwDOEq3cwc4B_4Fx",
             "repository_id": 313384129,
             "emoji": ":pray:",
             "name": "Q&A",

diff --git a/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_created.json b/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_created.json
@@ -4,6 +4,7 @@
         "repository_url": "https://api.github.com/repos/gsmet/quarkus-bot-java-playground",
         "category": {
             "id": 33522033,
+            "node_id": "DIC_kwDOEq3cwc4B_4Fx",
             "repository_id": 313384129,
             "emoji": ":pray:",
             "name": "Q&A",

diff --git a/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_labeled.json b/src/test/resources/org/kohsuke/github/GHEventPayloadTest/discussion_labeled.json
@@ -4,6 +4,7 @@
         "repository_url": "https://api.github.com/repos/gsmet/quarkus-bot-java-playground",
         "category": {
             "id": 33522033,
+            "node_id": "DIC_kwDOEq3cwc4B_4Fx",
             "repository_id": 313384129,
             "emoji": ":pray:",
             "name": "Q&A",