Skip to content

Commit

Permalink
Fix compiler error on tip of tree (project-chip#32575)
Browse files Browse the repository at this point in the history
* Fix compiler error on tip of tree

* Address PR comment
  • Loading branch information
tehampson authored and huangxuyong committed Mar 19, 2024
1 parent 860fdb1 commit 1b7e716
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/controller/AbstractDnssdDiscoveryController.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@ void AbstractDnssdDiscoveryController::OnNodeDiscovered(const chip::Dnssd::Disco
{
continue;
}
// TODO(#32576) Check if IP address are the same. Must account for `numIPs` in the list of `ipAddress`.
// Additionally, must NOT assume that the ordering is consistent.
if (strcmp(discoveredNode.resolutionData.hostName, nodeData.resolutionData.hostName) == 0 &&
discoveredNode.resolutionData.port == nodeData.resolutionData.port &&
discoveredNode.resolutionData.ipAddress == nodeData.resolutionData.ipAddress)
discoveredNode.resolutionData.numIPs == nodeData.resolutionData.numIPs)
{
discoveredNode = nodeData;
if (mDeviceDiscoveryDelegate != nullptr)
Expand Down

0 comments on commit 1b7e716

Please sign in to comment.