-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate pasted text in s-maxage #264
Comments
Sorry, been travelling. This was intentional (although I forgot to update the directive name). I agree this wasn't a great way to do it, though. I think the options are:
I think those are ordered according to my preferences, least to most. (I strongly suspect many people don't realise |
I agree with the conclusion, but am pretty sure that you meant to say s-maxage in that section defining s-maxage. That's all I changed, so it should be fine unless you wanted to add more text to explain why. I don't think it is necessary to explain more because adding s-maxage implies the server wants shared caches to reuse the response. |
I agree with @mnot that the additional semantics of So Could you please try to explain why the additional semantics of Thank you! |
Ah, okay, so the added paragraph had the right directive before but simply doesn’t make any sense given the context. |
The commit d4695a3 for #161 added a paragraph to s-maxage that contains the directive must-revalidate. I think this was supposed to say s-maxage and worded for shared caches?
The text was updated successfully, but these errors were encountered: