Npm prepare script #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from a comment on issue #6
This sets a
preparescript in package.json, which will run on build and also anytime the repo itself is installed (either as a local clone or via something like"dependencies": { "react-reverse-portal": "github:httptoolkit/react-reverse-portal#1fa7488" }).This ended up being much simpler than I realized:
prepareis a superset ofprepack, so just renaming the script seems to cover all of the cases.I also ran into an issue when trying to
npm run buildthe first time after cloning the repo, due to a typescript issue: there was no declaration file for the 'events' module (which is a sub-dependency of webpack). Installing@types/eventsfixed this, so this PR includes that change. I suspect that adding a package-lock might also fix it, but it looks like that's intentionally disabled so I didn't explore it.