Fix issue that could insta-crash Opera in some launches

It looks like new Opera releases have a UI bug where opening a URL that closes while the tab animation is happening (i.e. instantly) can crash the browser. It reloads and recovers (which is why the previous commit was required) but it would be nice to not do that. If we delay just 1ms this doesn't seem to happen any more, so let's do that.
httptoolkit · Feb 22, 2024 · b125ead · b125ead
1 parent 17e6513
commit b125ead
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/src/hide-warning-server.ts b/src/hide-warning-server.ts
@@ -9,7 +9,8 @@ import { EPHEMERAL_PORT_RANGE } from './constants';
 export class HideWarningServer {
 
     constructor(
-        private config: HtkConfig
+        private config: HtkConfig,
+        private options: { delay: number | undefined } = { delay: undefined }
     ) {}
 
     private server: Mockttp = getLocal();
@@ -37,11 +38,20 @@ export class HideWarningServer {
                 <script>
                     const targetUrl = ${JSON.stringify(targetUrl)};
                     window.open(targetUrl, '_blank');
-                    window.close();
+
+                    ${this.options.delay === undefined
+                        ? 'window.close();'
+                        // In some cases (Opera) closing too quickly can make the browser
+                        // crash, so we delay eeeeeever so slightly:
+                        : `setTimeout(() => {
+                            window.close();
+                        }, ${this.options.delay});`
+                    }
+
                 </script>
                 <body>
                     This page should disappear momentarily. If it doesn't, click
-                    <a href="${targetUrl}">this link</a>
+                    <a href="${targetUrl}">this link</a>.
                 </body>
             </html>
         `, { "content-type": "text/html" });

diff --git a/src/interceptors/chromium-based-interceptors.ts b/src/interceptors/chromium-based-interceptors.ts
@@ -97,7 +97,11 @@ abstract class FreshChromiumBasedInterceptor implements Interceptor {
     async activate(proxyPort: number, options: { webExtensionEnabled?: boolean } = {}) {
         const alreadyActive = this.isActive(proxyPort);
 
-        const hideWarningServer = new HideWarningServer(this.config);
+        const hideWarningServer = new HideWarningServer(this.config, {
+            delay: this.variantName === 'opera'
+                ? 1
+                : undefined
+        });
         await hideWarningServer.start('https://amiusing.httptoolkit.tech');
 
         const browserDetails = await getBrowserDetails(this.config.configPath, this.variantName);