Avoid needless reallocation of host & port strings on iOS

This is also extremely likely a memory leak since we're never cleaning these up - best to avoid that!
httptoolkit · Jun 12, 2024 · b96aac3 · b96aac3
1 parent b038788
commit b96aac3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ios/ios-connect-hook.js b/ios/ios-connect-hook.js
@@ -29,11 +29,11 @@ const nw_endpoint_create_host = new NativeFunction(
     'pointer', ['pointer', 'pointer']
 );
 
+const newHostStr = Memory.allocUtf8String(PROXY_HOST);
+const newPortStr = Memory.allocUtf8String(PROXY_PORT.toString());
+
 Interceptor.attach(nw_connection_create, {
     onEnter: function (args) {
-        const newHostStr = Memory.allocUtf8String(PROXY_HOST);
-        const newPortStr = Memory.allocUtf8String(PROXY_PORT.toString());
-
         // Replace the endpoint argument entirely with our own:
         args[0] = nw_endpoint_create_host(newHostStr, newPortStr);
     }