Improve API and implementation #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `RouteClassifier#orElse` and `UriTemplateClassifier#orElse` for combining classifiers. Add schema to `Tracer` creation in middlewares.
iRevive
reviewed
Jan 30, 2025
| val dsl = new Http4sDsl[F] {} | ||
| import dsl._ | ||
|
|
||
| RouteClassifier.of[F] { |
There was a problem hiding this comment.
It's a bit sad that we need to write it by hand, but it's amazing that we can have classifiers!
There was a problem hiding this comment.
sadly, I haven't figured out a good way to do it on the client end for UriTemplateClassifier
NthPortal
commented
Feb 4, 2025
trace/client/src/main/scala/org/http4s/otel4s/middleware/trace/client/AttributeProvider.scala
Outdated
Show resolved
Hide resolved
Minimise intermidiate collections created by `AttributeProvider` and `SpanDataProvider` when combined, and add tests for correct behaviour when combined.
samspills
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RouteClassifier#orElseandUriTemplateClassifier#orElseforcombining classifiers.
Add schema to
Tracercreation in middlewares.Minimise intermidiate collections created by
AttributeProviderand
SpanDataProviderwhen combined, and add tests for correctbehaviour when combined.