Add support for server-side request cancellation #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-anderson
commented
Jan 25, 2023
bryce-anderson
force-pushed
the
requestCancellation
branch
2 times, most recently
from
8a608df to
7415fe3
Compare
Problem Performing some server computations may be pretty expensive and in the case where the channel gets shutdown, either because the client hung up or the H2 stream was cancelled (due to a timeout, for example), the server will continue that processing in vein. Solution Propagate cancellation into the service handling logic in case it can save itself some work or potentially notify its own backends.
bryce-anderson
force-pushed
the
requestCancellation
branch
from
7415fe3 to
e0557fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Performing some server computations may be pretty expensive and in the case where the channel gets shutdown, either because the client hung up or the H2 stream was cancelled (due to a timeout, for example), the server will continue that processing in vein.
Solution
Propagate cancellation into the service handling logic in case it can save itself some work or potentially notify its own backends.