Logger: properly print debug from errors #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds the error type name. Fixes: http-rs#703
Fishrock123
commented
Oct 9, 2020
| @@ -50,7 +50,8 @@ impl LogMiddleware { | |||
| if status.is_server_error() { | |||
| if let Some(error) = response.error() { | |||
| log::error!("Internal error --> Response sent", { | |||
| message: format!("\"{}\"", error.to_string()), | |||
| message: format!("{:?}", error), | |||
There was a problem hiding this comment.
When using the Debug formatter on Nightly with RUST_BACKTRACE enabled, this will also print out with a backtrace.
Fishrock123
force-pushed
the
logger-error-backtrace
branch
from
aeb931f
to
c5854fb
Compare
|
I now have two codebases using custom loggers awaiting this, haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the error type name.
Fixes: #703