Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about domain/path inconsistencies to remove_cookie doc #533

Merged
merged 1 commit into from
May 23, 2020
Merged

Add warning about domain/path inconsistencies to remove_cookie doc #533

merged 1 commit into from
May 23, 2020

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented May 23, 2020 •
edited
Loading

Due to the way user agents are required to handle the Set-Cookie header, it is not possible to pass a cookie returned by Request::cookie to Response::remove_cookie if the cookie was originally set with either a domain or a path value.

This PR adds a note about this fact to the Response::remove_cookie documentation.

yoshuawuyts
yoshuawuyts approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic; thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 27310f9 into http-rs:master May 23, 2020
@kyrias kyrias deleted the cookie-removal-documentation branch May 24, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyrias @Fishrock123 @yoshuawuyts