Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request+Response AsRef and Into impls for inner context access #510

Merged
merged 2 commits into from
May 18, 2020
Merged

Request+Response AsRef and Into impls for inner context access #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee86c7
Response: impl AsRef and AsMut to http::Response
Fishrock123 May 17, 2020
2024ed2
Request: impl Into, AsRef, AsMut to http::Request
Fishrock123 May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,18 @@ impl<State> Request<State> {
}
}

impl<State> AsMut<http::Request> for Request<State> {
fn as_mut(&mut self) -> &mut http::Request {
&mut self.request
}
}

impl<State> AsRef<http::Request> for Request<State> {
fn as_ref(&self) -> &http::Request {
&self.request
}
}

impl<State> Read for Request<State> {
fn poll_read(
mut self: Pin<&mut Self>,
Expand All @@ -318,6 +330,12 @@ impl<State> Read for Request<State> {
}
}

impl<State> Into<http::Request> for Request<State> {
fn into(self) -> http::Request {
self.request
}
}

// NOTE: From cannot be implemented for this conversion because `State` needs to
// be constrained by a type.
impl<State: Send + Sync + 'static> Into<Response> for Request<State> {
Expand Down
12 changes: 12 additions & 0 deletions src/response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,18 @@ impl Response {
}
}

impl AsMut<http::Response> for Response {
fn as_mut(&mut self) -> &mut http::Response {
&mut self.res
}
}

impl AsRef<http::Response> for Response {
fn as_ref(&self) -> &http::Response {
&self.res
}
}

impl Into<http::Response> for Response {
fn into(self) -> http_types::Response {
self.res
Expand Down