Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response: expose remove_header #508

Merged
merged 1 commit into from
May 17, 2020

Conversation

Fishrock123
Copy link
Member

From http_types::Response

Useful for e.g. compression middleware where content-length is normally stripped.

From http_types::Response

Useful for e.g. compression middleware where content-length is normally stripped.
@Fishrock123
Copy link
Member Author

Fishrock123 commented May 17, 2020

It occurs to me that this is probably using the old HeaderName signature, but that doesn't appear to be updated for header and remove_header in http_types::Response compared to insert_header: https://docs.rs/http-types/1.2.0/http_types/struct.Response.html

@yoshuawuyts
Copy link
Member

@Fishrock123 it'll change again with http-types 2.0, which the next release of Tide will be blocked on. I'm happy to merge this as-is to enable this functionality (:

@yoshuawuyts yoshuawuyts merged commit 990b7a6 into http-rs:master May 17, 2020
@Fishrock123 Fishrock123 deleted the response-remove-header branch May 17, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants